Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMMOSGH34 : Add empty response checking/error handling for KMC Crypto #91

Merged
merged 1 commit into from
Mar 18, 2022
Merged

AMMOSGH34 : Add empty response checking/error handling for KMC Crypto #91

merged 1 commit into from
Mar 18, 2022
+59 −12

Conversation

IbraheemYSaleh
Copy link
Contributor

…Interface

@codecov-commenter
Copy link

Codecov Report

Merging #91 (770994a) into AMMOSGH29-install_target_dev (d3af74b) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@                      Coverage Diff                      @@
##           AMMOSGH29-install_target_dev      #91   +/-   ##
=============================================================
  Coverage                         83.51%   83.51%           
=============================================================
  Files                                18       18           
  Lines                              4227     4229    +2     
=============================================================
+ Hits                               3530     3532    +2     
  Misses                              697      697
Impacted Files Coverage Δ
src/src_main/crypto_tc.c 91.66% <75.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3af74b...770994a. Read the comment docs.

@IbraheemYSaleh
Copy link
Contributor Author

https://github.jpl.nasa.gov/ASEC/AMMOS-CryptoLib/issues/34

@IbraheemYSaleh
Copy link
Contributor Author

Note to self: Change base branch to dev before merge (after #90 is merged)

@jlucas9 jlucas9 merged commit 123dded into AMMOSGH29-install_target_dev Mar 18, 2022
@IbraheemYSaleh IbraheemYSaleh mentioned this pull request Mar 18, 2022
Merged
@jlucas9 jlucas9 deleted the AMMOSGH34 branch March 23, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbrown2 rjbrown2 rjbrown2 approved these changes

@jlucas9 jlucas9 jlucas9 approved these changes

@szemerick szemerick Awaiting requested review from szemerick

@dccutrig dccutrig Awaiting requested review from dccutrig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IbraheemYSaleh @codecov-commenter @jlucas9 @rjbrown2